[Refactor] Barcode scanning #8658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide richer response based on available data
SchrodingersGat
added
enhancement
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8658 +/- ##
==========================================
- Coverage 84.59% 84.04% -0.55%
==========================================
Files 1194 1195 +1
Lines 54353 55348 +995
Branches 2055 2057 +2
==========================================
+ Hits 45980 46518 +538
- Misses 7866 8320 +454
- Partials 507 510 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Improve get_supplier_part method - Error handling - Wrap calls to external plugins
…ee into barcode-scanning
|
This looks pretty useful! It (nearly) covers a use case I've been wanting to suggest: returning StockItems for 'minimized' EIGP 114.2018 barcodes containing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring implementation of custom supplier barcode scanning:
Headline Items
Ref: inventree/inventree-app#577
One of the major improvements here is that a supplier barcode plugin will return partial data on a generic "scan" request. Previously it would only return information responding to a supplier part.
However, suppliers will send packing lists with other information (purchase order number is a good example). So now you can scan that code in the app, the supplier barcode will recognize and return any field which is provided, and allows the app to navigate to the purchase order detail page.